Skip to content

Update varnish.rst #6770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update varnish.rst #6770

wants to merge 1 commit into from

Conversation

Dreimus
Copy link
Contributor

@Dreimus Dreimus commented Jul 26, 2016

remove word in vcl_recv doesnt exist in varnish 4.*

remove word in vcl_recv doesnt exist in varnish 4.*
@xabbuh
Copy link
Member

xabbuh commented Aug 3, 2016

@dbu Can you confirm this change?

@dbu
Copy link
Contributor

dbu commented Aug 4, 2016

seems correct: https://www.varnish-cache.org/docs/4.0/whats-new/upgrading.html#the-remove-keyword-is-gone

this fix should be applied to the oldest maintained version of the docs, its probably wrong in all branches.

@wouterj
Copy link
Member

wouterj commented Aug 5, 2016

Hi @Dreimus! Thank you for fixing this example.

As we restructured the documentation recently, this PR couldn't be merged as is. I've rebased your commit against the new changes and created #6848. You're still the author of the commit, so you get all credits you deserve.

Thanks again and I hope to see you back with more nice PRs! :)

@wouterj wouterj closed this Aug 5, 2016
wouterj added a commit that referenced this pull request Aug 11, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

Fix Varnish 4 code example

Finishes #6770

Original description:

 > remove word in vcl_recv doesnt exist in varnish 4.*

Commits
-------

4847fa5 Update varnish.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants